-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO-QA]: Company cards toggle #47719
[NO-QA]: Company cards toggle #47719
Conversation
# Conflicts: # src/libs/API/parameters/index.ts
assets/images/simple-illustrations/simple-illustration__twocards-horizontal.svg
Outdated
Show resolved
Hide resolved
Reviewer Checklist
Screenshots/VideosAndroid: Nativeancc2.webmAndroid: mWeb Chromeandcc1.webmiOS: NativeSimulator.Screen.Recording.-.iPhone.15.Pro.-.2024-08-22.at.00.10.02.mp4iOS: mWeb SafariSimulator.Screen.Recording.-.iPhone.15.Pro.-.2024-08-22.at.00.15.40.mp4MacOS: Chrome / SafariScreen.Recording.2024-08-21.at.23.43.54.movMacOS: DesktopScreen.Recording.2024-08-22.at.00.13.16.mov |
@narefyev91 are you getting a success response from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, for 404 api error I believe the backend isn't updated yet.
We did not find an internal engineer to review this PR, trying to assign a random engineer to #47376 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving again to assign an internal engineer.
# Conflicts: # src/CONST.ts # src/languages/en.ts # src/languages/es.ts # src/libs/Navigation/types.ts # src/pages/workspace/WorkspaceInitialPage.tsx
@iwiznia friendly bump on this one - we need this PR to merge to unblock others |
@iwiznia approved |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/iwiznia in version: 9.0.25-0 🚀
|
1 similar comment
🚀 Deployed to staging by https://github.com/iwiznia in version: 9.0.25-0 🚀
|
Details
Company cards toggle in workspace More features
Fixed Issues
$ #47376
PROPOSAL:
Tests
Test with collect Plan:
Test disabled toggle:
Offline tests
Same as above
QA Steps
Same as above
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
android-web.mov
iOS: Native
ios.mov
iOS: mWeb Safari
ios-web.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov
desktop2.mov